Fix package issues (#2691)

* Fix package issues and update circleci flow * Update acorn to latest version and change tests, see acornjs/acorn#806 * Update CircleCI config
rollup · Feb 14, 2019 · 67271e3 · 67271e3
1 parent 38f3ca6
commit 67271e3
Show file tree

Hide file tree

Showing 18 changed files with 412 additions and 370 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -1,17 +1,16 @@
+version: 2
+
 unit_tests: &unit_tests
   steps:
     - checkout
     - restore_cache:
         key: dependency-cache-{{ checksum "package-lock.json" }}
-    - run:
-        name: NPM Rebuild
-        command: npm install
     - run:
         name: Run unit tests.
         command: npm run ci:test
-version: 2
+
 jobs:
-  dependency_cache:
+  analysis:
     docker:
       - image: rollupcabal/circleci-node-base:latest
     steps:
@@ -20,31 +19,21 @@ jobs:
           key: dependency-cache-{{ checksum "package-lock.json" }}
       - run:
           name: Install Dependencies
-          command: npm install
+          command: npm ci
+      - run:
+          name: Run linting.
+          command: npm run lint
+      - run:
+          name: Run NPM Security Audit
+          command: npm run security
       - save_cache:
           key: dependency-cache-{{ checksum "package-lock.json" }}
           paths:
             - ./node_modules
   node-v6-latest:
     docker:
       - image: rollupcabal/circleci-node-v6:latest
-    steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ checksum "package-lock.json" }}
-      - run:
-          name: NPM Rebuild
-          command: npm install
-      - run:
-          name: Run unit tests.
-          command: npm run ci:test
-      # - run:
-      #     name: Run unit tests.
-      #     command: npm run ci:coverage
-      # - run:
-      #     name: Submit coverage data to codecov.
-      #     command: bash <(curl -s https://codecov.io/bash)
-      #     when: on_success
+    <<: *unit_tests
   node-v8-latest:
     docker:
       - image: rollupcabal/circleci-node-v8:latest
@@ -53,32 +42,19 @@ jobs:
     docker:
       - image: rollupcabal/circleci-node-v10:latest
     <<: *unit_tests
-  analysis:
-    docker:
-      - image: rollupcabal/circleci-node-base:latest
-    steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ checksum "package-lock.json" }}
-      - run:
-          name: NPM Rebuild
-          command: npm install
-      - run:
-          name: Run linting.
-          command: npm run lint
-      - run:
-          name: Run NPM Security Audit
-          command: npm run security
+      # - run:
+      #     name: Run unit tests.
+      #     command: npm run ci:coverage
+      # - run:
+      #     name: Submit coverage data to codecov.
+      #     command: bash <(curl -s https://codecov.io/bash)
+      #     when: on_success
 
-version: 2.0
 workflows:
   version: 2
   validate-test:
     jobs:
-      - dependency_cache
       - analysis:
-          requires:
-            - dependency_cache
           filters:
             tags:
               only: /.*/