Align batch warning for UNUSED_EXTERNAL_IMPORT to individual warning (#…

…4194) * Align batch warning for UNUSED_EXTERNAL_IMPORT to individual warning * assume not undefined * prettier * prettier * prettier * quotes * double quotes
rollup · Jul 29, 2021 · 586cb38 · 586cb38
1 parent e88c5c8
commit 586cb38
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/cli/run/batchWarnings.ts b/cli/run/batchWarnings.ts
@@ -237,7 +237,13 @@ const deferredHandlers: {
 	UNUSED_EXTERNAL_IMPORT(warnings) {
 		title('Unused external imports');
 		for (const warning of warnings) {
-			stderr(`${warning.names} imported from external module '${warning.source}' but never used`);
+			stderr(
+				warning.names +
+					' imported from external module "' +
+					warning.source +
+					'" but never used in ' +
+					printQuotedStringList((warning.sources as string[]).map(id => relativeId(id)))
+			);
 		}
 	}
 };

diff --git a/test/cli/samples/warn-import-export/_config.js b/test/cli/samples/warn-import-export/_config.js
@@ -16,7 +16,7 @@ module.exports = {
 		assertIncludes(
 			stderr,
 			'(!) Unused external imports\n' +
-				"default imported from external module 'external' but never used\n"
+				`default imported from external module "external" but never used in "main.js"\n`
 		);
 		assertIncludes(
 			stderr,