Protect all module globals for CJS output from being redefined (#2889)

src/Chunk.ts

@@ -1058,10 +1058,12 @@ export default class Chunk {
 		if (options.format !== 'es') {
 			usedNames.add('exports');
 			if (options.format === 'cjs') {
-				usedNames.add(INTEROP_DEFAULT_VARIABLE);
-				if (this.exportMode === 'default') {
-					usedNames.add('module');
-				}
+				usedNames
+					.add(INTEROP_DEFAULT_VARIABLE)
+					.add('require')
+					.add('module')
+					.add('__filename')
+					.add('__dirname');
 			}
 		}
 

test/form/samples/protect-cjs-globals/_config.js

@@ -0,0 +1,6 @@
+module.exports = {
+	description: 'prevent conflicts with cjs module globals',
+	options: {
+		output: { name: 'bundle' }
+	}
+};

test/form/samples/protect-cjs-globals/_expected/amd.js

@@ -0,0 +1,17 @@
+define(['exports'], function (exports) { 'use strict';
+
+	const exports$1 = 1;
+	const require = 2;
+	const module = 3;
+	const __filename = 4;
+	const __dirname = 5;
+
+	exports.__dirname = __dirname;
+	exports.__filename = __filename;
+	exports.exports = exports$1;
+	exports.module = module;
+	exports.require = require;
+
+	Object.defineProperty(exports, '__esModule', { value: true });
+
+});

test/form/samples/protect-cjs-globals/_expected/cjs.js

@@ -0,0 +1,15 @@
+'use strict';
+
+Object.defineProperty(exports, '__esModule', { value: true });
+
+const exports$1 = 1;
+const require$1 = 2;
+const module$1 = 3;
+const __filename$1 = 4;
+const __dirname$1 = 5;
+
+exports.__dirname = __dirname$1;
+exports.__filename = __filename$1;
+exports.exports = exports$1;
+exports.module = module$1;
+exports.require = require$1;

test/form/samples/protect-cjs-globals/_expected/es.js

@@ -0,0 +1,7 @@
+const exports = 1;
+const require = 2;
+const module = 3;
+const __filename = 4;
+const __dirname = 5;
+
+export { __dirname, __filename, exports, module, require };

test/form/samples/protect-cjs-globals/_expected/iife.js

@@ -0,0 +1,18 @@
+var bundle = (function (exports) {
+	'use strict';
+
+	const exports$1 = 1;
+	const require = 2;
+	const module = 3;
+	const __filename = 4;
+	const __dirname = 5;
+
+	exports.__dirname = __dirname;
+	exports.__filename = __filename;
+	exports.exports = exports$1;
+	exports.module = module;
+	exports.require = require;
+
+	return exports;
+
+}({}));

test/form/samples/protect-cjs-globals/_expected/system.js

@@ -0,0 +1,14 @@
+System.register('bundle', [], function (exports) {
+	'use strict';
+	return {
+		execute: function () {
+
+			const exports$1 = exports('exports', 1);
+			const require = exports('require', 2);
+			const module = exports('module', 3);
+			const __filename = exports('__filename', 4);
+			const __dirname = exports('__dirname', 5);
+
+		}
+	};
+});

test/form/samples/protect-cjs-globals/_expected/umd.js

@@ -0,0 +1,21 @@
+(function (global, factory) {
+	typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports) :
+	typeof define === 'function' && define.amd ? define(['exports'], factory) :
+	(global = global || self, factory(global.bundle = {}));
+}(this, function (exports) { 'use strict';
+
+	const exports$1 = 1;
+	const require = 2;
+	const module = 3;
+	const __filename = 4;
+	const __dirname = 5;
+
+	exports.__dirname = __dirname;
+	exports.__filename = __filename;
+	exports.exports = exports$1;
+	exports.module = module;
+	exports.require = require;
+
+	Object.defineProperty(exports, '__esModule', { value: true });
+
+}));

test/form/samples/protect-cjs-globals/main.js

@@ -0,0 +1,5 @@
+export const exports = 1;
+export const require = 2;
+export const module = 3;
+export const __filename = 4;
+export const __dirname = 5;

test/form/samples/sequence-expression/_expected/cjs.js

@@ -20,6 +20,6 @@ var e = (foo$1());
 var g = ((() => {console.log(foo$1());})(), 1);
 
 // should maintain this context
-var module = {};
-module.bar = function () { console.log( 'bar' );};
-var h = (0, module.bar)();
+var module$1 = {};
+module$1.bar = function () { console.log( 'bar' );};
+var h = (0, module$1.bar)();

test/function/samples/protect-cjs-globals/_config.js

@@ -0,0 +1,3 @@
+module.exports = {
+	description: 'prevent conflicts with cjs module globals'
+};

test/function/samples/protect-cjs-globals/main.js

@@ -0,0 +1,5 @@
+export const exports = 1;
+export const require = 2;
+export const module = 3;
+export const __filename = 4;
+export const __dirname = 5;