Fix performance regression when a file is imported by many importers (#…

…3641)
rollup · Jun 17, 2020 · 472b4be · 472b4be
1 parent cc2182d
commit 472b4be
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/Graph.ts b/src/Graph.ts
@@ -196,15 +196,15 @@ export default class Graph {
 		}
 		return {
 			dynamicallyImportedIds,
-			dynamicImporters: foundModule.dynamicImporters,
+			dynamicImporters: foundModule.dynamicImporters.sort(),
 			hasModuleSideEffects: foundModule.moduleSideEffects,
 			id: foundModule.id,
 			implicitlyLoadedAfterOneOf:
 				foundModule instanceof Module ? Array.from(foundModule.implicitlyLoadedAfter, getId) : [],
 			implicitlyLoadedBefore:
 				foundModule instanceof Module ? Array.from(foundModule.implicitlyLoadedBefore, getId) : [],
 			importedIds,
-			importers: foundModule.importers,
+			importers: foundModule.importers.sort(),
 			isEntry: foundModule instanceof Module && foundModule.isEntryPoint,
 			isExternal: foundModule instanceof ExternalModule
 		};

diff --git a/src/ModuleLoader.ts b/src/ModuleLoader.ts
@@ -294,7 +294,6 @@ export class ModuleLoader {
 						this.handleResolveId(await this.resolveId(source, module.id), source, module.id))
 				);
 				resolution.importers.push(module.id);
-				resolution.importers.sort();
 			}),
 			...module.dynamicImports.map(async dynamicImport => {
 				const resolvedId = await this.resolveDynamicImport(
@@ -312,7 +311,6 @@ export class ModuleLoader {
 						resolvedId
 					));
 					resolution.dynamicImporters.push(module.id);
-					resolution.dynamicImporters.sort();
 				}
 			})
 		]);