Do not check if the node itself has effects when checking call effects,

resolves #2729 (#2732)
rollup · Mar 1, 2019 · 43ed3c8 · 43ed3c8
1 parent 4ba9054
commit 43ed3c8
Show file tree

Hide file tree

Showing 3 changed files with 50 additions and 4 deletions.
diff --git a/src/ast/nodes/CallExpression.ts b/src/ast/nodes/CallExpression.ts
@@ -178,10 +178,10 @@ export default class CallExpression extends NodeBase implements DeoptimizableEnt
 		options: ExecutionPathOptions
 	): boolean {
 		if (options.hasReturnExpressionBeenCalledAtPath(path, this)) return false;
-		const innerOptions = options.addCalledReturnExpressionAtPath(path, this);
-		return (
-			this.hasEffects(innerOptions) ||
-			this.returnExpression.hasEffectsWhenCalledAtPath(path, callOptions, innerOptions)
+		return this.returnExpression.hasEffectsWhenCalledAtPath(
+			path,
+			callOptions,
+			options.addCalledReturnExpressionAtPath(path, this)
 		);
 	}
 

diff --git a/test/function/samples/nested-property-call-performance/_config.js b/test/function/samples/nested-property-call-performance/_config.js
@@ -0,0 +1,3 @@
+module.exports = {
+	description: 'handles nested property calls with acceptable performance'
+};
diff --git a/test/function/samples/nested-property-call-performance/main.js b/test/function/samples/nested-property-call-performance/main.js
@@ -0,0 +1,43 @@
+assert.equal(
+	'u'
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat('')
+		.concat(''),
+	'u'
+);