Update to latest plugins and extend file name sanitation (#2860)

package.json

@@ -74,7 +74,7 @@
     "acorn-walk": "^6.1.1",
     "ansi-escapes": "^4.1.0",
     "buble": "^0.19.7",
-    "chokidar": "^2.1.5",
+    "chokidar": "^2.1.6",
     "console-group": "^0.3.3",
     "date-time": "^3.1.0",
     "eslint": "^5.16.0",
@@ -98,17 +98,17 @@
     "remap-istanbul": "^0.13.0",
     "require-relative": "^0.8.7",
     "requirejs": "^2.3.6",
-    "rollup": "^1.11.3",
+    "rollup": "^1.12.0",
     "rollup-plugin-alias": "^1.5.1",
     "rollup-plugin-buble": "^0.19.6",
-    "rollup-plugin-commonjs": "^9.3.4",
+    "rollup-plugin-commonjs": "^10.0.0",
     "rollup-plugin-json": "^4.0.0",
-    "rollup-plugin-node-resolve": "^4.2.4",
+    "rollup-plugin-node-resolve": "^5.0.0",
     "rollup-plugin-replace": "^2.2.0",
     "rollup-plugin-string": "^3.0.0",
     "rollup-plugin-terser": "^4.0.4",
     "rollup-plugin-typescript": "^1.0.1",
-    "rollup-pluginutils": "^2.6.0",
+    "rollup-pluginutils": "^2.7.0",
     "sander": "^0.6.0",
     "shx": "^0.3.2",
     "signal-exit": "^3.0.2",

rollup.config.js

@@ -91,7 +91,7 @@ export default command => {
 			// acorn needs to be external as some plugins rely on a shared acorn instance
 			external: ['fs', 'path', 'events', 'module', 'util', 'crypto', 'acorn', 'tty', 'net', 'url'],
 			treeshake: {
-				pureExternalModules: true,
+				moduleSideEffects: false,
 				propertyReadSideEffects: false
 			},
 			output: [
@@ -113,7 +113,7 @@ export default command => {
 			],
 			external: ['fs', 'path', 'module', 'events', 'rollup', 'assert', 'os', 'util'],
 			treeshake: {
-				pureExternalModules: true,
+				moduleSideEffects: false,
 				propertyReadSideEffects: false
 			},
 			output: {
@@ -150,7 +150,7 @@ export default command => {
 				terser({ module: true, output: { comments: 'some' } })
 			],
 			treeshake: {
-				pureExternalModules: true,
+				moduleSideEffects: false,
 				propertyReadSideEffects: false
 			},
 			output: [

src/utils/sanitizeFileName.ts

@@ -1,3 +1,3 @@
 export function sanitizeFileName(name: string): string {
-	return name.replace(/[\0]/g, '_');
+	return name.replace(/[\0?*]/g, '_');
 }

test/chunking-form/samples/preserve-modules-commonjs/_expected/amd/commonjs.js

@@ -1,4 +1,4 @@
-define(['exports', 'external', './other', './_virtual/_commonjs-external-external', './_virtual/other'], function (exports, external, __chunk_1, __chunk_2, __chunk_3) { 'use strict';
+define(['exports', 'external', './other', './_virtual/_external_commonjs-external', './_virtual/other.js_commonjs-proxy'], function (exports, external, __chunk_1, __chunk_2, __chunk_3) { 'use strict';
 
 	external = external && external.hasOwnProperty('default') ? external['default'] : external;
 

test/chunking-form/samples/preserve-modules-commonjs/_expected/cjs/commonjs.js

@@ -2,8 +2,8 @@
 
 require('external');
 require('./other.js');
-var __chunk_2 = require('./_virtual/_commonjs-external-external');
-var __chunk_3 = require('./_virtual/other.js');
+var __chunk_2 = require('./_virtual/_external_commonjs-external');
+var __chunk_3 = require('./_virtual/other.js_commonjs-proxy');
 
 const { value } = __chunk_3.default;
 

test/chunking-form/samples/preserve-modules-commonjs/_expected/es/commonjs.js

@@ -1,7 +1,7 @@
 import 'external';
 import './other.js';
-import external from './_virtual/_commonjs-external-external';
-import require$$0 from './_virtual/other.js';
+import external from './_virtual/_external_commonjs-external';
+import require$$0 from './_virtual/other.js_commonjs-proxy';
 
 const { value } = require$$0;
 

test/chunking-form/samples/preserve-modules-commonjs/_expected/system/commonjs.js

@@ -1,4 +1,4 @@
-System.register(['external', './other.js', './_virtual/_commonjs-external-external', './_virtual/other.js'], function (exports, module) {
+System.register(['external', './other.js', './_virtual/_external_commonjs-external', './_virtual/other.js_commonjs-proxy'], function (exports, module) {
 	'use strict';
 	var external, require$$0;
 	return {