use more readonly

rollup · Jan 23, 2022 · 31e2bf4 · 31e2bf4
1 parent a50cde0
commit 31e2bf4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/src/Module.ts b/src/Module.ts
@@ -1004,12 +1004,14 @@ export default class Module {
 
 	private addRelevantSideEffectDependencies(
 		relevantDependencies: Set<Module | ExternalModule>,
-		necessaryDependencies: Set<Module | ExternalModule>,
-		alwaysCheckedDependencies: Set<Module | ExternalModule>
+		necessaryDependencies: ReadonlySet<Module | ExternalModule>,
+		alwaysCheckedDependencies: ReadonlySet<Module | ExternalModule>
 	): void {
 		const handledDependencies = new Set<Module | ExternalModule>();
 
-		const addSideEffectDependencies = (possibleDependencies: Set<Module | ExternalModule>) => {
+		const addSideEffectDependencies = (
+			possibleDependencies: ReadonlySet<Module | ExternalModule>
+		) => {
 			for (const dependency of possibleDependencies) {
 				if (handledDependencies.has(dependency)) {
 					continue;

diff --git a/src/utils/chunkAssignment.ts b/src/utils/chunkAssignment.ts
@@ -6,8 +6,8 @@ type DependentModuleMap = Map<Module, Set<Module>>;
 type ChunkDefinitions = { alias: string | null; modules: Module[] }[];
 
 export function getChunkAssignments(
-	entryModules: Module[],
-	manualChunkAliasByEntry: Map<Module, string>
+	entryModules: readonly Module[],
+	manualChunkAliasByEntry: ReadonlyMap<Module, string>
 ): ChunkDefinitions {
 	const chunkDefinitions: ChunkDefinitions = [];
 	const modulesInManualChunks = new Set<Module>(manualChunkAliasByEntry.keys());
@@ -54,8 +54,8 @@ export function getChunkAssignments(
 	}
 
 	function areEntryPointsContainedOrDynamicallyDependent(
-		entryPoints: Set<Module>,
-		containedIn: Set<Module>
+		entryPoints: ReadonlySet<Module>,
+		containedIn: ReadonlySet<Module>
 	): boolean {
 		const entriesToCheck = new Set(entryPoints);
 		for (const entry of entriesToCheck) {
@@ -96,7 +96,7 @@ function addStaticDependenciesToManualChunk(
 	entry: Module,
 	manualChunkModules: Module[],
 	modulesInManualChunks: Set<Module>
-) {
+): void {
 	const modulesToHandle = new Set([entry]);
 	for (const module of modulesToHandle) {
 		modulesInManualChunks.add(module);
@@ -109,7 +109,7 @@ function addStaticDependenciesToManualChunk(
 	}
 }
 
-function analyzeModuleGraph(entryModules: Module[]): {
+function analyzeModuleGraph(entryModules: readonly Module[]): {
 	dependentEntryPointsByModule: DependentModuleMap;
 	dynamicEntryModules: Set<Module>;
 } {
@@ -142,7 +142,7 @@ function analyzeModuleGraph(entryModules: Module[]): {
 
 function getDynamicDependentEntryPoints(
 	dependentEntryPointsByModule: DependentModuleMap,
-	dynamicEntryModules: Set<Module>
+	dynamicEntryModules: ReadonlySet<Module>
 ): DependentModuleMap {
 	const dynamicallyDependentEntryPointsByDynamicEntry: DependentModuleMap = new Map();
 	for (const dynamicEntry of dynamicEntryModules) {
@@ -164,7 +164,7 @@ function getDynamicDependentEntryPoints(
 }
 
 function createChunks(
-	allEntryPoints: Module[],
+	allEntryPoints: readonly Module[],
 	assignedEntryPointsByModule: DependentModuleMap
 ): ChunkDefinitions {
 	const chunkModules: { [chunkSignature: string]: Module[] } = Object.create(null);