deprecation deprecations

bin/src/run/batchWarnings.ts

@@ -95,7 +95,7 @@ const immediateHandlers: {
 				? `'${warning.modules[0]}'`
 				: `${warning.modules
 						.slice(0, -1)
-						.map(name => `'${name}'`)
+						.map((name: string) => `'${name}'`)
 						.join(', ')} and '${warning.modules.slice(-1)}'`;
 		stderr(
 			`Creating a browser bundle that depends on ${detail}. You might need to include https://www.npmjs.com/package/rollup-plugin-node-builtins`

bin/src/run/index.ts

@@ -105,22 +105,12 @@ function execute(configFile: string, configs: InputOptions[], command: any) {
 		for (const config of configs) {
 			promise = promise.then(() => {
 				const warnings = batchWarnings();
-				const { inputOptions, outputOptions, deprecations, optionError } = mergeOptions({
+				const { inputOptions, outputOptions, optionError } = mergeOptions({
 					config,
 					command,
 					defaultOnWarnHandler: warnings.add
 				});
 
-				if (deprecations.length) {
-					inputOptions.onwarn({
-						code: 'DEPRECATED_OPTIONS',
-						message: `The following options have been renamed — please update your config: ${deprecations
-							.map(option => `${option.old} -> ${option.new}`)
-							.join(', ')}`,
-						deprecations
-					});
-				}
-
 				if (optionError) inputOptions.onwarn({ code: 'UNKNOWN_OPTION', message: optionError });
 				return build(inputOptions, outputOptions, warnings, command.silent);
 			});

bin/src/run/watch.ts

@@ -69,10 +69,6 @@ export default function watch(
 
 			if (!result.watch) result.watch = {};
 
-			if (merged.deprecations.length) {
-				(<{ _deprecations: any }>result.watch)._deprecations = merged.deprecations;
-			}
-
 			if (merged.optionError)
 				merged.inputOptions.onwarn({
 					message: merged.optionError,

rollup.config.js

@@ -29,6 +29,8 @@ const banner = `/*
 */`;
 
 const onwarn = warning => {
+	if (warning.pluginCode === 'ONWRITE_HOOK_DEPRECATED')
+		return;
 	// eslint-disable-next-line no-console
 	console.error(
 		'Building Rollup produced warnings that need to be resolved. ' +

src/ast/nodes/Identifier.ts

@@ -10,7 +10,6 @@ import { ImmutableEntityPathTracker } from '../utils/ImmutableEntityPathTracker'
 import { LiteralValueOrUnknown, ObjectPath, UNKNOWN_EXPRESSION, UNKNOWN_VALUE } from '../values';
 import LocalVariable from '../variables/LocalVariable';
 import Variable from '../variables/Variable';
-import AssignmentExpression from './AssignmentExpression';
 import AssignmentPattern from './AssignmentPattern';
 import * as NodeType from './NodeType';
 import Property from './Property';

src/rollup/index.ts

@@ -4,7 +4,6 @@ import Graph from '../Graph';
 import { createAddons } from '../utils/addons';
 import { createAssetPluginHooks, finaliseAsset } from '../utils/assetHooks';
 import commondir from '../utils/commondir';
-import { Deprecation } from '../utils/deprecateOptions';
 import error from '../utils/error';
 import { writeFile } from '../utils/fs';
 import getExportMode from '../utils/getExportMode';
@@ -21,14 +20,9 @@ import {
 	OutputOptions,
 	Plugin,
 	RollupBuild,
-	RollupSingleFileBuild,
-	WarningHandler
+	RollupSingleFileBuild
 } from './types';
 
-function checkInputOptions(_options: any) {
-	// no deprecations currently
-}
-
 function checkOutputOptions(options: OutputOptions) {
 	if (<string>options.format === 'es6') {
 		error({
@@ -68,7 +62,6 @@ function getInputOptions(rawInputOptions: GenericConfigObject): any {
 
 	if (optionError) inputOptions.onwarn({ message: optionError, code: 'UNKNOWN_OPTION' });
 
-	checkInputOptions(inputOptions);
 	const plugins = inputOptions.plugins;
 	inputOptions.plugins = Array.isArray(plugins) ? plugins : plugins ? [plugins] : [];
 	inputOptions = inputOptions.plugins.reduce(applyOptionHook, inputOptions);
@@ -481,7 +474,6 @@ function normalizeOutputOptions(
 
 	// now outputOptions is an array, but rollup.rollup API doesn't support arrays
 	const outputOptions = mergedOptions.outputOptions[0];
-	const deprecations = mergedOptions.deprecations;
 
 	checkOutputOptions(outputOptions);
 

src/rollup/types.d.ts

@@ -7,23 +7,28 @@ export interface IdMap {
 	[key: string]: string;
 }
 
-export interface RollupError {
-	message: string;
+export interface RollupError extends RollupLogProps {
+	message?: string;
+	stack?: string;
+}
+
+export interface RollupWarning extends RollupLogProps {
+	message?: string;
+}
+
+export interface RollupLogProps {
 	code?: string;
-	name?: string;
 	url?: string;
-	id?: string;
+	plugin?: string;
+	pluginCode?: string;
+	hook?: string;
 	loc?: {
 		file?: string;
 		line: number;
 		column: number;
 	};
-	stack?: string;
 	frame?: string;
-	pos?: number;
-	plugin?: string;
-	pluginCode?: string;
-	hook?: string;
+	[key: string]: any;
 }
 
 export interface ExistingRawSourceMap {
@@ -242,14 +247,12 @@ export interface InputOptions {
 	experimentalDynamicImport?: boolean;
 	experimentalTopLevelAwait?: boolean;
 	inlineDynamicImports?: boolean;
+	preferConst?: boolean;
 	preserveSymlinks?: boolean;
 	experimentalPreserveModules?: boolean;
 	optimizeChunks?: boolean;
 	chunkGroupingSize?: number;
 	shimMissingExports?: boolean;
-
-	/** @deprecated */
-	preferConst?: boolean;
 }
 
 export type ModuleFormat = 'amd' | 'cjs' | 'system' | 'es' | 'esm' | 'iife' | 'umd';
@@ -304,35 +307,6 @@ export interface OutputOptionsDir extends OutputOptions {
 	dir?: string;
 }
 
-export interface RollupWarning {
-	message?: string;
-	code?: string;
-	loc?: {
-		file: string;
-		line: number;
-		column: number;
-	};
-	deprecations?: { old: string; new: string }[];
-	modules?: string[];
-	names?: string[];
-	source?: string;
-	importer?: string;
-	frame?: any;
-	missing?: string;
-	exporter?: string;
-	exportName?: string;
-	name?: string;
-	sources?: string[];
-	reexporter?: string;
-	guess?: string;
-	url?: string;
-	id?: string;
-	plugin?: string;
-	pos?: number;
-	pluginCode?: string;
-	hook?: string;
-}
-
 export type WarningHandler = (warning: string | RollupWarning) => void;
 
 export interface SerializedTimings {

src/utils/mergeOptions.ts

@@ -1,5 +1,4 @@
 import { InputOptions, OutputOptions, WarningHandler } from '../rollup/types';
-import deprecateOptions, { Deprecation } from './deprecateOptions';
 
 export interface GenericConfigObject {
 	[key: string]: any;
@@ -82,20 +81,16 @@ export const commandAliases: { [key: string]: string } = {
 export default function mergeOptions({
 	config = {},
 	command: rawCommandOptions = {},
-	deprecateConfig,
 	defaultOnWarnHandler
 }: {
 	config: GenericConfigObject;
 	command?: GenericConfigObject;
-	deprecateConfig?: GenericConfigObject;
 	defaultOnWarnHandler?: WarningHandler;
 }): {
 	inputOptions: any;
 	outputOptions: any;
-	deprecations: Deprecation[];
 	optionError: string | null;
 } {
-	const deprecations = deprecate(config, rawCommandOptions, deprecateConfig);
 	const command = getCommandOptions(rawCommandOptions);
 	const inputOptions = getInputOptions(config, command, defaultOnWarnHandler);
 
@@ -145,7 +140,6 @@ export default function mergeOptions({
 	return {
 		inputOptions,
 		outputOptions,
-		deprecations,
 		optionError: unknownOptionErrors.length > 0 ? unknownOptionErrors.join('\n') : null
 	};
 }
@@ -221,18 +215,6 @@ function getInputOptions(
 		watch: config.watch
 	};
 
-	// legacy to make sure certain plugins still work
-	if (Array.isArray(inputOptions.input)) {
-		inputOptions.entry = inputOptions.input[0];
-	} else if (typeof inputOptions.input === 'object') {
-		for (const name in inputOptions.input) {
-			inputOptions.entry = inputOptions.input[name];
-			break;
-		}
-	} else {
-		inputOptions.entry = inputOptions.input;
-	}
-
 	return inputOptions;
 }
 
@@ -272,40 +254,3 @@ function getOutputOptions(
 		strict: getOption('strict', true)
 	};
 }
-
-function deprecate(
-	config: GenericConfigObject,
-	command: GenericConfigObject = {},
-	deprecateConfig: GenericConfigObject = { input: true, output: true }
-): Deprecation[] {
-	const deprecations = [];
-
-	// CLI
-	if (command.id) {
-		deprecations.push({
-			old: '-u/--id',
-			new: '--amd.id'
-		});
-		(command.amd || (command.amd = {})).id = command.id;
-	}
-
-	if (typeof command.output === 'string') {
-		deprecations.push({
-			old: '--output',
-			new: '--file'
-		});
-		command.output = { file: command.output };
-	}
-
-	if (command.d) {
-		deprecations.push({
-			old: '-d',
-			new: '--indent'
-		});
-		command.indent = command.d;
-	}
-
-	// config file
-	deprecations.push(...deprecateOptions(config, deprecateConfig));
-	return deprecations;
-}

src/utils/pluginDriver.ts

@@ -1,7 +1,15 @@
 import { EventEmitter } from 'events';
 import { version as rollupVersion } from 'package.json';
 import Graph from '../Graph';
-import { InputOptions, Plugin, PluginCache, PluginContext, RollupError, RollupWarning, SerializablePluginCache } from '../rollup/types';
+import {
+	InputOptions,
+	Plugin,
+	PluginCache,
+	PluginContext,
+	RollupError,
+	RollupWarning,
+	SerializablePluginCache
+} from '../rollup/types';
 import { createAssetPluginHooks, EmitAsset } from './assetHooks';
 import { getRollupDefaultPlugin } from './default-plugin';
 import error from './error';
@@ -80,6 +88,17 @@ export function createPluginDriver(
 			cacheInstance = uncacheablePlugin(plugin.name);
 		}
 
+		const firstWatchHandler = true;
+
+		function deprecatedWatchListener(event: string, handler: () => void) {
+			if (firstWatchHandler)
+				context.warn({
+					code: 'PLUGIN_WATCHER_DEPRECATED',
+					message: `this.watcher usage is deprecated in plugins. Use the watchChange plugin hook instead.`
+				});
+			return watcher.on(event, handler);
+		}
+
 		const context: PluginContext = {
 			addWatchFile(id: string) {
 				if (graph.finished) this.error('addWatchFile can only be called during the build.');
@@ -113,7 +132,13 @@ export function createPluginDriver(
 				warning.plugin = plugin.name || `Plugin at position ${pidx + 1}`;
 				graph.warn(warning);
 			},
-			watcher
+			watcher: watcher
+				? <EventEmitter>{
+						...watcher,
+						on: deprecatedWatchListener,
+						addListener: deprecatedWatchListener
+				  }
+				: undefined
 		};
 		return context;
 	});