Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

fix: respect setting the deprecated fields "module", "main", and "jsn… #204

Merged
merged 1 commit into from Apr 6, 2019
Merged

fix: respect setting the deprecated fields "module", "main", and "jsn… #204

merged 1 commit into from Apr 6, 2019

Conversation

cecilia-sanare
Copy link
Contributor

Description

This fixes an issue where setting any of the following would have zero impact on what fields were referenced.

module.exports = {
  plugins: [
    // The issue also occurred if they were set individually as well.
    resolve({
      main: false,
      module: false,
      jsnext: false
    })
  ]
}

Related Issues

closes #203

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this fix + adding the missing tests 👍

@lukastaegert lukastaegert merged commit 853a5f5 into rollup:master Apr 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4.1.0 doesn't respect modules: false anymore
2 participants