Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Add .d.ts typings file #189

Merged
merged 4 commits into from Apr 5, 2019
Merged

Add .d.ts typings file #189

merged 4 commits into from Apr 5, 2019

Conversation

NotWoods
Copy link
Member

Adds a .d.ts TypeScript declaration file to support typechecking a Rollup config with TypeScript.

TypeScript allows for checking normal Javascript files by adding a // @ts-check comment at the top of the file. By providing typings users can check that they aren't passing misspelled or incorrect parameters, and see a hint about what each option does in their editor.

typings-demo-node-resolve

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks again for this PR as well! If you merge master, then this should solve the CI issue on Node 6. Otherwise you should probably check if the typings are distributed with the package :)

@NotWoods
Copy link
Member Author

NotWoods commented Apr 5, 2019

Rebased and fixed package.json!

@lukastaegert
Copy link
Member

Awesome quick response, thanks!

@Kocal
Copy link
Contributor

Kocal commented Apr 9, 2019

Nice improvments! :)
I've just created a PR (DefinitelyTyped/DefinitelyTyped#34598) to remove types from DefinitlyTyped repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants