fix: ignore virtual modules from other plugins (#327)

* fix: ignore virtual modules from other plugins Closes #315 * Add test that virtual modules are ignored
rollup · Sep 18, 2018 · e6063ea · e6063ea
1 parent 5936873
commit e6063ea
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 5 deletions.
diff --git a/src/index.js b/src/index.js
@@ -71,12 +71,17 @@ export default function commonjs ( options = {} ) {
 	let entryModuleIdsPromise = null;
 
 	function resolveId ( importee, importer ) {
-		if ( importee === HELPERS_ID ) return importee;
-
-		if ( importer && startsWith( importer, PREFIX ) ) importer = importer.slice( PREFIX.length );
-
 		const isProxyModule = startsWith( importee, PREFIX );
-		if ( isProxyModule ) importee = importee.slice( PREFIX.length );
+		if ( isProxyModule ) {
+			importee = importee.slice( PREFIX.length );
+		}
+		else if ( startsWith( importee, '\0' ) ) {
+			return importee;
+		}
+
+		if ( importer && startsWith( importer, PREFIX ) ) {
+			importer = importer.slice( PREFIX.length );
+		}
 
 		return resolveUsingOtherResolvers( importee, importer ).then( resolved => {
 			if ( resolved ) return isProxyModule ? PREFIX + resolved : resolved;

diff --git a/test/samples/ignore-virtual-modules/main.js b/test/samples/ignore-virtual-modules/main.js
@@ -0,0 +1 @@
+module.exports = require('\0virtual');
diff --git a/test/test.js b/test/test.js
@@ -576,5 +576,19 @@ describe( 'rollup-plugin-commonjs', () => {
 				assert.equal( error.frame, '1: export const foo = 2,\n                        ^' );
 			}
 		});
+
+		it('ignores virtual modules', async () => {
+			const bundle = await rollup({
+				input: 'samples/ignore-virtual-modules/main.js',
+				plugins: [ commonjs(), {
+					load (id) {
+						if (id === '\0virtual') {
+							return 'export default "Virtual export"';
+						}
+					}
+				} ]
+			});
+			assert.equal( (await executeBundle( bundle )).exports, 'Virtual export' );
+		});
 	});
 });