Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(typescript): code in src sub-directory #682

Merged
merged 2 commits into from
Dec 7, 2020
Merged

test(typescript): code in src sub-directory #682

merged 2 commits into from
Dec 7, 2020

Conversation

benmccann
Copy link
Contributor

Rollup Plugin Name: typescript

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

Add a disabled test for #287

@shellscape
Copy link
Collaborator

What's the benefit of adding a test that won't be run?

@benmccann
Copy link
Contributor Author

I had a couple goals:

Copy link
Member

@NotWoods NotWoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a common issue so I'm happy to have a test written for it. Thanks for the help!

@shellscape shellscape merged commit 26e2a00 into rollup:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants