New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(babel): strip hash and query param in extension filter #533
Conversation
@Andarist failing CI aside, where do we stand on this one? |
@csr632 could you take a look at the CI failures please? |
abc2fe5
to
0efe4bf
Compare
The CI is fixed, but we still need to decide how to handle both of these appropriately:
Should we extract this logic into |
In light of #588 I think we should NOT add special handling for |
Considering that without special handling for |
6afad53
to
9f79b72
Compare
I just update this PR to reflect this. It is ready to be reviewed. @lukastaegert @Andarist |
Rollup Plugin Name:
@rollup/plugin-babel
This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers: Fix: #500
Description
When babel plugin is filtering module by file extensions, it should consider paths that contains hash and query param, and strip them out before doing file extension matching.
The motivation and implementation is similar to how node-resolve plugin support hash and query.