Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(babel): export * as ns support #511

Merged
merged 4 commits into from Aug 3, 2020
Merged

feat(babel): export * as ns support #511

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b659573
declares export * as ns support
JLHwung Jul 27, 2020
949ab6d
check rollup version
JLHwung Jul 29, 2020
6544750
oof
JLHwung Jul 29, 2020
a1857f1
refactor: get rollupVersion from this.meta in options hook
JLHwung Jul 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/babel/package.json
View file
Open in desktop
Expand Up @@ -47,7 +47,7 @@
"peerDependencies": {
"@babel/core": "^7.0.0",
"@types/babel__core": "^7.1.9",
"rollup": "^1.20.0||^2.0.0"
"rollup": "^1.26.0||^2.0.0"
},
"dependencies": {
"@babel/helper-module-imports": "^7.7.4",
Expand Down
1 change: 1 addition & 0 deletions packages/babel/src/index.js
View file
Open in desktop
Expand Up @@ -45,6 +45,7 @@ const unpackInputPluginOptions = ({ skipPreflightCheck = false, ...rest }) => {
supportsStaticESM: true,
supportsDynamicImport: true,
supportsTopLevelAwait: true,
supportsExportNamespaceFrom: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be possible to make this conditional (from Rollup's perspective) to avoid changing peer dep range and thus avoid this being a breaking change. I bet it should be rather easily possible to read Babel's version somehow as well, right?

Copy link
Contributor Author

@JLHwung JLHwung Jul 29, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need detect Babel version, undeclared caller flags will be considered as noop for preset-env.

I have updated PR to check rollup versions. however it seems that I can not retrieve version from rollup/package.json.

...rest.caller
}
});
Expand Down