-
-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wasm): Switch to TypeScript & named exports #363
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,9 @@ | ||
const { builtinModules } = require('module'); | ||
import typescript from '@rollup/plugin-typescript'; | ||
import { createConfig } from '../../shared/rollup.config'; | ||
|
||
const pkg = require('./package.json'); | ||
import pkg from './package.json'; | ||
|
||
const dependencies = Object.keys(pkg.dependencies || {}); | ||
|
||
export default [ | ||
{ | ||
input: 'src/index.js', | ||
output: { exports: 'named', file: 'dist/index.js', format: 'cjs' }, | ||
external: [...builtinModules, ...dependencies] | ||
} | ||
]; | ||
export default { | ||
...createConfig(pkg), | ||
plugins: [typescript()], | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import { Plugin } from 'rollup'; | ||
|
||
export interface RollupWasmOptions { | ||
/** | ||
* Specifies an array of strings that each represent a WebAssembly file to load synchronously. | ||
*/ | ||
sync?: readonly string[]; | ||
} | ||
|
||
/** | ||
* 🍣 A Rollup which allows importing and bundling [WebAssembly modules](http://webassembly.org). | ||
*/ | ||
export function wasm(options?: RollupWasmOptions): Plugin; | ||
export default wasm; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import { builtinModules } from 'module'; | ||
|
||
/** | ||
* Create a base rollup config | ||
* @param {*} pkg Imported package.json | ||
* @returns {import('rollup').RollupOptions} | ||
*/ | ||
export function createConfig(pkg) { | ||
return { | ||
input: 'src/index.ts', | ||
external: Object.keys(pkg.dependencies || {}).concat(builtinModules), | ||
output: [ | ||
{ | ||
format: 'cjs', | ||
file: pkg.main, | ||
exports: 'named', | ||
footer: 'module.exports = Object.assign(exports.default, exports);' | ||
}, | ||
{ | ||
format: 'esm', | ||
file: pkg.module | ||
} | ||
] | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this with the latest version of the typescript plugin, or will that do definition file output for us now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment the types folder is a bit cleaner. I'm still refining the declaration output for the typescript plugin.