fix(pluginutils): createFilter Windows regression #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellscape
requested review from
NotWoods,
bterlson,
Kocal,
pnevares,
TrySound,
wesleygrimes,
wuweiweiwu and
a team
|
Pushing this one out, as it's a pretty big regression. |
LarsDenBakker
pushed a commit
to LarsDenBakker/plugins
that referenced
this pull request
Sep 12, 2020
* fix(pluginutils): createFilter windows regression * chore: diagnose windows * chore: remove comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
pluginutilsThis PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Something recently changed with the Windows containers on Github Actions and a few tests that were passing were suddenly not. (I suspect a bugfix on their end, perhaps something to do with WSL) But that revealed a regression in the code that was added in #84 for a fix for paths that included parens.
The fix for this was a refactor of that code. Additionally, several more characters that could be used in globs are now escaped.