Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(commonjs): correctly wrap a default class export from cjs module #1350

Merged
merged 2 commits into from Nov 27, 2022
Merged

fix(commonjs): correctly wrap a default class export from cjs module #1350

merged 2 commits into from Nov 27, 2022

Commits on Nov 19, 2022

  1. fix: correctly wraps the default export from a CommonJS module when i… 

    …t is a class

Fixes https://github.com/vitejs/vite/issues/10853

Since rollup@3c00191
the namespace became callable when requiring ESM with function default,
but it isn't newable, leading to errors when the function is actually a
class.
    @sodatea
    sodatea committed Nov 19, 2022
    Copy the full SHA
    32cd0c8 View commit details
    Browse the repository at this point in the history

  2. test: update snapshots as the helper code has changed

    @sodatea
    sodatea committed Nov 19, 2022
    Copy the full SHA
    354b65e View commit details
    Browse the repository at this point in the history