Merge pull request #85 from rollup/use-onwarn-if-available

Use options.onwarn if available
rollup · Dec 17, 2019 · 665ba1b · 665ba1b
1 parent b91d7f3
commit 665ba1b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/packages/rollup-plugin-babel/src/index.js b/packages/rollup-plugin-babel/src/index.js
@@ -26,9 +26,15 @@ export default function babel ( options ) {
 	if ( options.externalHelpers ) externalHelpers = true;
 	delete options.externalHelpers;
 
+	let warn = msg => console.warn(msg); // eslint-disable-line no-console
+
 	return {
 		name: 'babel',
 
+		options ( options ) {
+			warn = options.onwarn || warn;
+		},
+
 		resolveId ( id ) {
 			if ( id === HELPERS ) return id;
 		},
@@ -64,7 +70,7 @@ export default function babel ( options ) {
 				} else {
 					usedHelpers.forEach( helper => {
 						if ( inlineHelpers[ helper ] ) {
-							warnOnce( `The '${helper}' Babel helper is used more than once in your code. It's strongly recommended that you use the "external-helpers" plugin or the "es2015-rollup" preset. See https://github.com/rollup/rollup-plugin-babel#configuring-babel for more information` );
+							warnOnce( warn, `The '${helper}' Babel helper is used more than once in your code. It's strongly recommended that you use the "external-helpers" plugin or the "es2015-rollup" preset. See https://github.com/rollup/rollup-plugin-babel#configuring-babel for more information` );
 						}
 
 						inlineHelpers[ helper ] = true;

diff --git a/packages/rollup-plugin-babel/src/utils.js b/packages/rollup-plugin-babel/src/utils.js
@@ -6,8 +6,8 @@ export function assign ( target, source ) {
 }
 
 let warned = {};
-export function warnOnce ( msg ) {
+export function warnOnce ( warn, msg ) {
 	if ( warned[ msg ] ) return;
 	warned[ msg ] = true;
-	console.warn( msg ); // eslint-disable-line no-console
+	warn( msg );
 }
diff --git a/packages/rollup-plugin-babel/test/test.js b/packages/rollup-plugin-babel/test/test.js
@@ -179,13 +179,12 @@ describe( 'rollup-plugin-babel', function () {
 
 	it( 'warns on duplicated helpers', () => {
 		let messages = [];
-		console.warn = msg => messages.push( msg );
 
 		return rollup.rollup({
 			entry: 'samples/duplicated-helpers-warning/main.js',
-			plugins: [ babelPlugin() ]
+			plugins: [ babelPlugin() ],
+			onwarn: msg => messages.push( msg )
 		}).then( () => {
-			console.warn = consoleWarn;
 			assert.deepEqual( messages, [
 				'The \'classCallCheck\' Babel helper is used more than once in your code. It\'s strongly recommended that you use the "external-helpers" plugin or the "es2015-rollup" preset. See https://github.com/rollup/rollup-plugin-babel#configuring-babel for more information'
 			]);