Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add halted_callback to the log output #373

Closed
wants to merge 1 commit into from

Conversation

jeremybdk
Copy link

Sometimes when you do the final render or redirection, it can be halted by a controller callback. With the existing code, it can very hard to understand where it stopped.

With this commit, the intent is to provide the method name where it stops.

So I started from #259 work and because it was not maintained anymore I moved the code the to base subscriber to have the halted callback.

Would that be the way to do it? Not sure but I try to keep @benoittgt code and integrate it in the codebase

Sometimes when you do the final render or redirection, it can be
halted by a controller callback. With the existing code, it can
very hard to understand where it stopped.

With this commit, the intent is to provide the method name where
it stops.
@jeremybdk
Copy link
Author

Actually it won't work for all the case like this, need to figure out how to do this properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants