Log RecordNotFound as 404

[pxlpnk]

This is an attempt/proposal to fix #110 and parts of #27.
It will correctly log an ActiveRecord::RecordNotFound as a 404 and other things coming back from AR and others.

It will however not log a ActionController::RoutingError as this is out of reach with the current implementation. See the referenced issues for this.

[benlovell]

👍

[jturkel]

@pxlpnk - Any plans to release a new version of the gem with this fix?

[benlovell]

@jturkel I'll cut a release. Watch this space.

[kitop]

Is there a way to do the same for ActionController::RoutingError?

[benlovell]

@kitop Did you try the latest release? It should have been resolved by #134

[kitop]

Yes.
We're using 0.3.3, and still seeing some of those logging.

Eg:

ActionController::RoutingError (No route matches [GET] "/assets/images/wordpress.jpg"):
  actionpack (4.2.3) lib/action_dispatch/middleware/debug_exceptions.rb:21:in `call'
  newrelic_rpm (3.12.0.288) lib/new_relic/agent/instrumentation/middleware_tracing.rb:67:in `call'
  actionpack (4.2.3) lib/action_dispatch/middleware/show_exceptions.rb:30:in `call'
  newrelic_rpm (3.12.0.288) lib/new_relic/agent/instrumentation/middleware_tracing.rb:67:in `call'
  lograge (0.3.3) lib/lograge/rails_ext/rack/logger.rb:15:in `call_app'
  railties (4.2.3) lib/rails/rack/logger.rb:20:in `block in call'

Any ideas why it could happen?

[pxlpnk]

This happens in the rack stack. lograge currently can not handle those errors.
In general rails has two (two my knowledge) kind of 404 exceptions. One being from ActiveRecord when a record is not found and the other from the routing stack that is handled in rack.

[kitop]

Ah, gotcha. Thanks for the explanation @pxlpnk!!