Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testscript: fix ptyName() returning /dev/pts/4294967296 on s390x #246

Merged
merged 1 commit into from
Feb 16, 2024

Commits on Feb 16, 2024

  1. testscript: fix ptyName() returning /dev/pts/4294967296 on s390x

    Use uint32 instead of uint (64-bit in Go on s390x) to store the return
    value of the TIOCGPTN syscall.  This is to avoid the 32-bit value from
    being stored into a 64-bit buffer and get left-shifted by 32 when
    dereferencing, turning what should be /dev/pts/1 to /dev/pts/4294967296
    on big-endian architectures such as s390x.
    
    Special thanks to the explanation and a similar bug fix provided at
    containerd/console#51
    anthonyfok committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    86ed44b View commit details
    Browse the repository at this point in the history