use filepath.WalkDir, add TestScript.Name #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can easily save hundreds of stat calls per test script, particularly when testing Go tools. While here, remove a few uses of the deprecated io/ioutil in cmd, and check some missed errors in txtar-c.
This will be useful in some cmd/cue test scripts where we want each test to create a unique remote resource that includes the current test name as a prefix, for the sake of more easily seeing which test created which resource.
|
FYI, the second commit is needed for the cmd/cue e2e tests. The first commit I had stashed for a couple of weeks and forgot about :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit messages - please do not squash)