Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: provide more context on maintainers and give a testscript overview with links #225

Merged
merged 4 commits into from
May 24, 2023

Conversation

thepudds
Copy link
Contributor

@thepudds thepudds commented May 7, 2023

Help give some context for people who might be evaluating using this repo and are wondering things like:

  • what is the bus factor for the repo?
  • who are the maintainers?
  • are the maintainer(s) of this repo still interested in this repo (including, are they still using it)?
  • are other people using testscript?
  • where did testscript come from?

Obviously, someone can hunt around to determine many of these things on their own, but intent is to help make that process more efficient.

Updates #196

@bitfield
Copy link
Contributor

bitfield commented May 7, 2023

It's worth knowing that the Links header is special: it causes any listed links to be shown in the right-hand pane on pkg.go.dev.

@thepudds
Copy link
Contributor Author

thepudds commented May 7, 2023

Hi @bitfield 👋

It's worth knowing that the Links header golang/go#42968: it causes any listed links to be shown in the right-hand pane on pkg.go.dev.

Ah, interesting, TIL.

I guess I don't know how often people are browsing the root https://pkg.go.dev/github.com/rogpeppe/go-internal on pkg.go.dev (vs. browsing API for an importable package), and I guess the "Links" link in the right-hand pane hasn't been jumping out to me personally.

My thought was to put the link in a sentence along with words like "introduction" and "nice" and "series" to encourage interested people to click, but I don't have a strong opinion.

As the target of said link, any preference regarding which form to use?

ldemailly added a commit to fortio/testscript that referenced this pull request May 7, 2023
Borrowed the better text from rogpeppe#225
ldemailly added a commit to fortio/testscript that referenced this pull request May 7, 2023
Borrowed the better text from rogpeppe#225
ldemailly added a commit to fortio/testscript that referenced this pull request May 7, 2023
* Better README text

Borrowed the better text from rogpeppe#225

* add explanation about link section

and try if it still works with ## instead of #
@ldemailly
Copy link

ldemailly commented May 7, 2023

I tested with https://github.com/fortio/testscript/blob/v0.3.1/README.md and you can use ## for links so it's smaller when looking on github and yet still on pkg.go.dev (and I guess probably ### or #### would also work)

Copy link
Collaborator

@myitcv myitcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much, @thepudds.

LGTM with a couple of suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Collaborator

@myitcv myitcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much, @thepudds.

LGTM with a couple of suggestions.

@mvdan
Copy link
Collaborator

mvdan commented May 8, 2023

SGTM :) Perhaps worth making a mention that testscript and txtar were both originally written by Russ. We don't want to give the impression that we came up with the idea.

…ntion original author, other minor adjustments

Mostly based on review feedback.
@thepudds
Copy link
Contributor Author

thepudds commented May 8, 2023

Thanks for the quick feedback! I think I addressed your comments.

PTAL.

Should be the last tweak from me in this series, pending further feedback.
@ldemailly
Copy link

You don't want to keep/add back ### Links for pkg.go.dev?

Copy link
Collaborator

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo is under @rogpeppe's name, so I'd like a review from him as well.

Copy link
Owner

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mvdan mvdan merged commit ec11942 into rogpeppe:master May 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants