testscript: fix "signal: killed" exec errors on MacOS by using os.Symlink on darwin #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bep
force-pushed
the
fix/unexpectedcommandfailuretake3
branch
from
d5b8976
to
bc3969b
Compare
bep
changed the title
|
I wonder if we should support hard links at all, then. I chose hard links because symlinks can cause more trouble, but empirically, hard links are causing trouble as well. Symlinks are better on MacOS, and they shouldn't be worse on Linux. If you replace |
bep
force-pushed
the
fix/unexpectedcommandfailuretake3
branch
from
bc3969b
to
886643a
Compare
|
@mvdan I have force pushed a version that uses |
By using `os.Symlink` instead of `os.Link`.. See rogpeppe#200
bep
force-pushed
the
fix/unexpectedcommandfailuretake3
branch
from
886643a
to
68c86dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
os.Symlinkon Darwin.See #200