update cache and lockedfile packages #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be passing CI now; I had to use a slightly older version of |
As of commit 7a21f799a5ac23d3e191a106d71af9b8f65279fd, which is crucially right before https://go.dev/cl/476917, as then internal/filelock starts using Go 1.21's errors.ErrUnsupported. We still want to support Go 1.19 and 1.20 for a while. The only change besides the import path rewriting is to drop testenv, which was only used for MustHaveExec and Command. Note that we no longer need to worry about unix build tags, as we now require Go 1.19 or later.
As of commit 0fd6ae548f550bdbee4a434285ff052fb9dc7417. Besides rewriting import paths, we swapped base.Fatalf with log.Fatalf, and replaced cfg.Getenv with os.Getenv, adding a note about the difference in behavior. The old code already had this limitation. We hadn't updated this package since it was first copied in 2018, so quite a few changes have taken place. Of note, it now supports mmap; leave that out for now, to keep this commit simple and to leave adding the mmap package for another patch. A minor API change is that Trim now returns an error. While technically a breaking change, the vast majority of users will be simply calling the API without expecting a result, and that will continue to work like it did before. Checking for errors on trim is useful, which is why upstream added it. Finally, the cache now uses lockedfile, which we already copied over.
rogpeppe
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit messages - please do not squash)
Particularly the cache package, since I want to use it soon and it hadn't been updated since 2018.