all: deprecate wrapper packages #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People should in general be using the upstream packages rather than these. Also use the upstream packages directly when possible and remove some tests that aren't testing code in this module any more.
mvdan
approved these changes
Mar 27, 2023
cueckoo
pushed a commit
to cue-lang/cue-trybot
that referenced
this pull request
May 6, 2023
Since rogpeppe/go-internal#213, the former is a deprecated package forwarding to the latter. I imagine this was a goimports mistake, since the package already imports x/mod/module. Signed-off-by: Daniel Martí <mvdan@mvdan.cc> Change-Id: Ib41871a4ed2e57e5221c7f9b4802848b8a26f312 Dispatch-Trailer: {"type":"trybot","CL":553571,"patchset":1,"ref":"refs/changes/71/553571/1","targetBranch":"master"}
cueckoo
pushed a commit
to cue-lang/cue
that referenced
this pull request
May 7, 2023
Since rogpeppe/go-internal#213, the former is a deprecated package forwarding to the latter. I imagine this was a goimports mistake, since the package already imports x/mod/module. Signed-off-by: Daniel Martí <mvdan@mvdan.cc> Change-Id: Ib41871a4ed2e57e5221c7f9b4802848b8a26f312 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/553571 Unity-Result: CUEcueckoo <cueckoo+gerrithub@cuelang.org> Reviewed-by: Paul Jolly <paul@myitcv.io> TryBot-Result: CUEcueckoo <cueckoo+gerrithub@cuelang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People should in general be using the upstream packages rather than these. Also use the upstream packages directly when possible and remove some tests that aren't testing code in this module any more.