renameio: implement in terms of github.com/google/renameio/v2 #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
reviewed
Mar 27, 2023
There was a problem hiding this comment.
I'm just reminded that the public renameio does not support Windows by design; see https://pkg.go.dev/github.com/google/renameio/v2#readme-windows-support.
There is https://pkg.go.dev/github.com/google/renameio/v2@v2.0.0/maybe#WriteFile which is best-effort, falling back to ioutil.WriteFile on Windows. We might want to use that for WriteFile, to not break Windows, but then I'm not sure what we should do with WriteToFile.
Maybe we don't forward this package due to the Windows awkwardness, but only deprecate it?
Yeah, not a bad idea. I'll abandon this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.