Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: add support for txtar extension and prefer it #159

Merged
merged 1 commit into from Jun 24, 2022

Commits on Jun 17, 2022

  1. all: add support for txtar extension and prefer it

    For backwards compatibility, both testscript and goproxytest, which used
    to glob on `*.txt`, now look for both file extensions.
    Note that this required a bit of a refactor in testscript,
    as we cannot use a single glob expression to accomplish this.
    
    Code which produces files, such as txtar-addmod, now produces `*.txtar`
    rather than `*.txt`. Similarly, the public docs now use `*.txtar` too.
    
    Note that we leave many txt files in tests untouched;
    it's unnecessary to change them given the backwards compatibility,
    and it has zero benefit to the user as they aren't public.
    Moreover, the diff churn would make this patch harder to review.
    If a future version of go-internal only supports txtar extensions,
    then it could replace all of those extensions accordingly.
    
    Fixes rogpeppe#126.
    mvdan committed Jun 17, 2022
    Copy the full SHA
    77f96e5 View commit details
    Browse the repository at this point in the history