Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testscript: workaround quardratic behaviour of github.com/pkg/diff #137

Merged
merged 1 commit into from
Mar 29, 2021

Commits on Mar 29, 2021

  1. testscript: workaround quardratic behaviour of github.com/pkg/diff

    The current version of github.com/pkg/diff.Diff has quadratic behaviour.
    This means that when we attempt a diff between relatively modest sized
    files, it's easy to find yourself out of memory.
    
    Therefore, when we see a diff between two large files (large defined in
    terms of number of lines), tersely report that as if the two were binary
    files, i.e. do not try to render the diff.
    
    When github.com/pkg/diff or similar supports a linear algorithm:
    
    golang/go#45200 (comment)
    
    we can revert this change.
    myitcv committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    8329eeb View commit details
    Browse the repository at this point in the history