Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump JDK running Gradle from 11 to 17 #9

Merged
merged 1 commit into from Nov 29, 2021
Merged

Commits on Nov 29, 2021

  1. Bump JDK running Gradle from 11 to 17

    This commit decouples the JDK running Gradle from the one building the
    project.
    
    Gradle will by default use the same JDK for building the project as it
    does for running Gradle. Newer JDKs are assumed to be more performant,
    contain fewer bugs and to come with desirable features that we would
    like to utilize in our build, but doing so should not endanger
    backwards compatibility for the plugin itself. We can do that now by
    utilizing Gradle toolchains, which allows us to use one JDK/JRE for
    running Gradle and the other for building the project, i.e. executing
    `javac`.
    
    Doing this requires us to make multiple JDKs available to the Gradle
    build action for each individual execution of the build. The setup-java
    action doesn't support this at the moment, and the multiple build steps
    configured for actions/setup-java in this commit is at best a
    workaround for this, and at worst a bad assumption with respect to
    environment variables or other settings being overwritten. Furthermore,
    there's no handling of duplicate invocations of the action.
    
    Hopefully both actions/setup-java and gradle/gradle-build-action will
    handle all of this gracefully.
    
    For more details, see:
    - actions/setup-java#44
    - gradle/gradle#14903
    rognan committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    c93a0e7 View commit details
    Browse the repository at this point in the history