Set FLAG_HARDWARE_ACCELERATED in ShadowPackageManger.addActivityIfNotPresent #9032
+9
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_628494031
branch
4 times, most recently
from
5267ca2
to
fdef0c0
Compare
copybara-service
bot
force-pushed
the
piper_628494031
branch
from
fdef0c0
to
2492a60
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
piper_628494031
branch
from
2492a60
to
c534dcb
Compare
…Present Previously, only Activities that were present in an AndroidManifest.xml would contain the FLAG_HARDWARE_ACCELERATED window flag, which gets populated by PackageParser. This means that Activities not present in a manifest could not be rendered with a HardwareRenderer, as it would get ignored due to the missing flag. This meant that the HW rendering version of PixelCopy would not operate on that Activity. The FLAG_HARDWARE_ACCELERATED was true by default since Android ICS (SDK 14), so it should be true by default in Robolectric as well. Fixes #8982 PiperOrigin-RevId: 628494031
copybara-service
bot
force-pushed
the
piper_628494031
branch
from
c534dcb
to
786e2cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set FLAG_HARDWARE_ACCELERATED in ShadowPackageManger.addActivityIfNotPresent
Previously, only Activities that were present in an AndroidManifest.xml would
contain the FLAG_HARDWARE_ACCELERATED window flag, which gets
populated by PackageParser. This means that Activities not
present in a manifest could not be rendered with a HardwareRenderer, as it
would get ignored due to the missing flag. This meant that the HW rendering
version of PixelCopy would not operate on that Activity.
The FLAG_HARDWARE_ACCELERATED was true by default since
Android ICS (SDK 14), so it should be true by default in Robolectric
as well.
Fixes #8982