Use real Android framework code in the ViewConfiguration(Context) ctor #9022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_627083356
branch
from
6894bd0
to
6131a9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use real Android framework code in the ViewConfiguration(Context) ctor
Previously, calling ViewConfiguration.get(Context) did not invoke the
underlying Android framework code. This caused a lot of important
initialization logic to be skipped, and most of the 'scaled' fields in
ViewConfiguration to be uninitialized.
Update ShadowViewConfiguration to shadow the ViewConfiguration(Context)
constructor. This shadow method will call the original real
ViewConfiguration(Context) constructor, and then apply the Robolectric
customizations.
Most of the Robolectric customizations are also incorrect, but these can be
whittled down later.