Drop support for KITKAT SDK and associated dead code cleanup. #9020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
MGaetan89
reviewed
Apr 23, 2024
nativeruntime/src/test/java/org/robolectric/nativeruntime/DefaultNativeRuntimeLazyLoadTest.java
Outdated
Show resolved
Hide resolved
shadows/framework/src/main/java/org/robolectric/shadows/ShadowICU.java
Outdated
Show resolved
Hide resolved
shadows/framework/src/main/java/org/robolectric/shadows/ShadowPausedMessageQueue.java
Outdated
Show resolved
Hide resolved
|
sorry for distraction this isn't ready for review yet |
copybara-service
bot
force-pushed
the
piper_627151694
branch
from
464df7f
to
67239e6
Compare
copybara-service
bot
changed the title
MGaetan89
reviewed
Apr 24, 2024
...sts/androidx_test/src/sharedTest/java/org/robolectric/integrationtests/axt/EspressoTest.java
Outdated
Show resolved
Hide resolved
shadows/framework/src/main/java/org/robolectric/shadows/ShadowPaint.java
Outdated
Show resolved
Hide resolved
copybara-service
bot
force-pushed
the
piper_627151694
branch
from
67239e6
to
979289c
Compare
MGaetan89
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Just a couple more comments related to your changes, then it looks good to me.
I've checkout the branch locally, and I noticed that there are still some declarations that may be removed?
- many
@Implementation(maxSdk = JELLY_BEAN - many places are still checking for API level >= LOLLIPOP
ShadowPackageParser.callParsePackage(Path)checks forRuntimeEnvironment.getApiLevel() >= Build.VERSION_CODES.LOLLIPOPShadowLocaleData.setEnUsLocaleData(LocaleData)checks forgetApiLevel() >= LOLLIPOPShadowLocationManager.getLegacyLocationRequests(String)'s comment still reference KitKatShadowLocationManager.RoboLocationRequest's comment still reference KitKat
Not sure if it's the scope of this PR, but AndroidManifest.getMinSdkVersion() and AndroidManifest.getTargetSdkVersion() still return 19 by default.
Since Robolectric min SDK version is still 19, this may be expected for now.
| @@ -403,90 +339,48 @@ private static void throwsIfOutOfBounds(int len, int offset, int count) { | |||
| } | |||
|
|
|||
| // nativeWriteBlob was introduced in lollipop, thus no need for a int nativePtr variant | |||
There was a problem hiding this comment.
Is this comment still needed?
| } | ||
|
|
||
| @Implementation(minSdk = LOLLIPOP) | ||
| @Implementation | ||
| protected static byte[] nativeCreateByteArray(long nativePtr) { | ||
| return NATIVE_BYTE_BUFFER_REGISTRY.getNativeObject(nativePtr).createByteArray(); | ||
| } | ||
|
|
||
| // nativeReadBlob was introduced in lollipop, thus no need for a int nativePtr variant |
copybara-service
bot
force-pushed
the
piper_627151694
branch
from
979289c
to
fa34d5b
Compare
copybara-service
bot
force-pushed
the
piper_627151694
branch
from
fa34d5b
to
c577257
Compare
|
oops sorry auto submittal of this PR was in progress already. Good comments, will address in a followup |
MGaetan89
added a commit
to MGaetan89/robolectric
that referenced
this pull request
May 1, 2024
MGaetan89
added a commit
to MGaetan89/robolectric
that referenced
this pull request
May 1, 2024
MGaetan89
added a commit
to MGaetan89/robolectric
that referenced
this pull request
May 3, 2024
MGaetan89
added a commit
to MGaetan89/robolectric
that referenced
this pull request
May 6, 2024
MGaetan89
added a commit
to MGaetan89/robolectric
that referenced
this pull request
May 19, 2024
MGaetan89
added a commit
to MGaetan89/robolectric
that referenced
this pull request
May 23, 2024
MGaetan89
added a commit
to MGaetan89/robolectric
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop support for KITKAT SDK and associated dead code cleanup.
The android ecosystem is moving to support a minimum of minSdkVersion L,
and thus Robolectric is following suit and dropping support for running on
SDKs < L (21).
This change does the following:
run explicitly on KitKat (e.g Config(sdk = 19) will now fail with
'unsupported sdk' errors.
such as removing @implementation or unit tests with a maxSdk of < L.
@config references.