Support HttpEngine openConnection(URL) #8973
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
changed the title
utzcoz
reviewed
Apr 6, 2024
robolectric/src/test/java/org/robolectric/android/HttpEngineTest.java
Outdated
Show resolved
Hide resolved
yschimke
force-pushed
the
httpengine
branch
2 times, most recently
from
179cd7b
to
766cf0a
Compare
|
@yschimke There are some CI checking, including code style, commit validation. You can find them by checking GitHub Actions configurations. |
yschimke
force-pushed
the
httpengine
branch
5 times, most recently
from
943976c
to
9c67d17
Compare
|
This current version is platform agnostic. So I suggest this is a separate task. Also probably worth running the instrumentation tasks on a later Android emulator. |
|
I was considering adding a shadow API to set a different cronet provider that would work for grpc and http3. But I figured a follow up. |
|
cc @fridek |
yschimke
force-pushed
the
httpengine
branch
3 times, most recently
from
d55ae62
to
4c5ce7e
Compare
yschimke
commented
Apr 7, 2024
integration_tests/ctesque/src/sharedTest/java/android/net/http/HttpEngineTest.java
Outdated
Show resolved
Hide resolved
utzcoz
reviewed
Apr 9, 2024
integration_tests/ctesque/src/sharedTest/java/android/net/http/HttpEngineTest.java
Outdated
Show resolved
Hide resolved
Use the JavaCronetProvider from cronet-fallback. Implement just enough to support URLConnection.
|
@utzcoz anything I need to do on this, or just waiting for additional review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
First attempt at #8956.
For discussion and advice on structure and tests.
Proposed Changes
Bridge to the JavaCronetProvider from cronet-fallback, that just uses URLConnection.