Remove unnecessary androidx.test core and ext.junit dependencies from shadow tests. #8896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
… shadow tests. Shadow tests should be lower layer than androidx, and its good to minimize dependencies. The impetus for making this change now is a forthcoming androidx.test change will add new dependencies whose exported manifest permissions causes ShadowPackageManagerTest#queryPermissionsByGroup_nullMatchesPermissionsNotAssociatedWithGroup to fail. PiperOrigin-RevId: 613715910
MGaetan89
reviewed
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary androidx.test core and ext.junit dependencies from shadow tests.
Shadow tests should be lower layer than androidx, and its good to minimize dependencies.
The impetus for making this change now is a forthcoming androidx.test change will add
new dependencies whose exported manifest permissions causes
ShadowPackageManagerTest#queryPermissionsByGroup_nullMatchesPermissionsNotAssociatedWithGroup to fail.