Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Javadocs for ShadowContentResolver #8879

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shashankiitbhu
Copy link

Fixes #8874

I updated Java docs for all the @Deprecated methods with more helpful instructions and also added Java docs for other @Deprecated Methods.

@utzcoz
Copy link
Member

utzcoz commented Feb 27, 2024

@shashankiitbhu Please squash your commits to one.

@shashankiitbhu
Copy link
Author

shashankiitbhu commented Feb 27, 2024

@shashankiitbhu Please squash your commits to one.

Done, everything is in "Squashed Commits"

@utzcoz
Copy link
Member

utzcoz commented Feb 28, 2024

@shashankiitbhu You have 9 commits now. Please squash to only one commit.

@shashankiitbhu
Copy link
Author

@shashankiitbhu You have 9 commits now. Please squash to only one commit.

oh sorry, It's done now.

@utzcoz
Copy link
Member

utzcoz commented Mar 9, 2024

@shashankiitbhu Please ensure your commit meets the CI checking. You can check and run validation commands locally, and you can check what .github/workflows does.

@shashankiitbhu shashankiitbhu force-pushed the update_javadoc_pr_8874 branch 2 times, most recently from 1a8f405 to 6807972 Compare March 11, 2024 15:37
Updated Deprecated Javadocs For ShadowContentResolver
@shashankiitbhu
Copy link
Author

@utzcoz @hoisie Please Review and merge this PR, thanks

@MGaetan89
Copy link
Contributor

@utzcoz @hoisie friendly ping to review this PR 🙂

@MGaetan89
Copy link
Contributor

@utzcoz @hoisie friendly ping to review this PR 🙂

@utzcoz @hoisie did you have time to have a look at this PR?

@utzcoz
Copy link
Member

utzcoz commented May 3, 2024

@MGaetan89 Thanks for your ping. @shashankiitbhu Please rebase your PR based on latest master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Javadoc for ShadowContentResolver about deprecation notices
4 participants