ShadowTelephonyManager instances remember their ids #8751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Methods that used to ignore subId, phoneId, slotIndex, or PhoneAccountHandle parameters will now redirect to the proper TelephonyManager instance, making a new instance if needed. Methods that used hardcoded 0 as the id now use the associated id if any, but still fall back to 0 to preserve legacy tests. #getCurrentPhoneType now reads from the preexisting map. This was a preexisting bug revealed by this CL. The shadowForSubId(...) and similar methods are public to make it trivial for users to correctly create new instances. Added a #context() method to make it easier/faster to access the context for each TelephonyManager instance. PiperOrigin-RevId: 596083118
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShadowTelephonyManager instances remember their ids
Methods that used to ignore subId, phoneId, slotIndex, or PhoneAccountHandle parameters will now redirect to the proper TelephonyManager instance, making a new instance if needed.
Methods that used hardcoded 0 as the id now use the associated id if any, but still fall back to 0 to preserve legacy tests.
#getCurrentPhoneType now reads from the preexisting map. This was a preexisting bug revealed by this CL.
The shadowForSubId(...) and similar methods are public to make it trivial for users to correctly create new instances.
Added a #context() method to make it easier/faster to access the context for each TelephonyManager instance.