Replace looseSignature with a better annotation

[utzcoz]

If one method of a shadow class uses the Class that brought by newer SDK than user's compileSdk, and it will cause compiling error for user because Robolectri's Shadows loads this shadow class, and trigger this shadow class to load this new Class. In previous experience, we use looseSignatures to mark shadow class and use Object to replace all input parameters of this method to avoid compiling error and ensure ShadowWrangle can find this method. looseSignatures work fine now, but it's coarse-grained. ClassName can be used to mark the input parameter that has new Class type only, and ShadowWrangle will provide type checking for real input parameter to ensure real passed input parameters match to expected class types.

Close #6888.

[utzcoz]

After converting left looseSignature with ClassName as much as possible, I will try to migrate ClassName to the existing WithType as #6884 (comment) suggested.

[utzcoz]

@hoisie @brettchabot Although this work is not finished completely, but I think it's time to receive feedback from your experience early.

[hoisie]

This is great!

[hoisie]

Checking it now

[hoisie]

FYI these are the annotation processor errors that get printed:

https://gist.github.com/hoisie/12c2e4f4c3f35a45dd22e1175cdfd9bd

Looks like the validator errors need to be updated as well to support ClassName:

https://github.com/robolectric/robolectric/blob/master/processor/src/main/java/org/robolectric/annotation/processing/validator/SdkStore.java#L145

https://github.com/robolectric/robolectric/blob/master/processor/src/main/java/org/robolectric/annotation/processing/validator/ImplementsValidator.java

It seems like the sdk validator doesn't run on Gradle?

[utzcoz]

@hoisie Thanks. I will continue this work with ClassName, but I want to replace it with existing WithType at last. I will check annotation error and try to fix it at next update.

It seems like the sdk validator doesn't run on Gradle?

Looks like not run. I didn't capture this error when running this PR locally and GitHub Actions.

[hoisie]

You mean the @WithType from reflector? I was hoping to keep the reflector annotations separate from the shadow annotations, even if there was a little bit of overlap. I kind of see reflector as a stand-along library.

[utzcoz]

I was hoping to keep the reflector annotations separate from the shadow annotations, even if there was a little bit of overlap.

Okay. I will keep to use ClassName for upcoming changes.

It seems like the sdk validator doesn't run on Gradle?

Which command can be used to run validator? Normal assemble building? We might need to add this checking task on GitHub CI if it doesn't run on CI before.

[utzcoz]

Moved to #8829 after fixing branch name.