Add looper mode assertions to ShadowChoreographer methods
#7278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_443503854
branch
from
c4d7c00
to
36e1f2e
Compare
copybara-service
bot
force-pushed
the
piper_443503854
branch
from
36e1f2e
to
ea68d95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add looper mode assertions to
ShadowChoreographermethodsIt's error prone to call these methods with the wrong looper mode as they don't do anything, assert that the looper mode is supported. The caller can easily wrap the method call in a looper mode check if a test must support multiple looper modes (which is unusual).
Fixes a bug in the
AnimationRunnerwhere it was not incrementing the elapsed time for the animation by the correct increment for the paused looper.