Make ShadowPendingIntent implement is___ methods of PendingIntent #7268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
The methods isActivity, isBroadcast, isForegroundService, isService and isImmutable were added in API level 31. They currently throw NullPointerException when called in the simulated Robolectric environment. This change implements these methods using the pre-existing is___Intent methods of ShadowPendingIntent. PiperOrigin-RevId: 443407199
copybara-service
bot
force-pushed
the
piper_443407199
branch
from
3041878
to
aab115d
Compare
|
@hoisie Looks like this PR was merged. It might can be closed. I don't know whether I can close PRs that created by copybara directly. |
hoisie
force-pushed
the
google
branch
4 times, most recently
from
adcb531
to
842b431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make ShadowPendingIntent implement is___ methods of PendingIntent
The methods isActivity, isBroadcast, isForegroundService, isService
and isImmutable were added in API level 31. They currently throw
NullPointerException when called in the simulated Robolectric
environment.
This change implements these methods using the pre-existing
is___Intent methods of ShadowPendingIntent.