Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate compileSdkVersion to compileSdk #7253

Merged
merged 1 commit into from Apr 19, 2022

Conversation

Akshay2131
Copy link
Contributor

Overview

Migrated compileSdkVersion to compileSdk for Robolectric's tests.
Close: #6950

Proposed Changes

Robolectric uses AGP 7.1.0 and starting from the release of AGP 7.0.0, we can use compileSdk instead of compileSdkVersion.
So, i changed compileSdkVersion to compileSdk.

@utzcoz
Copy link
Member

utzcoz commented Apr 17, 2022

@Akshay2131 It's recommend to learn how to rebase on the same PR, instead of creating multiple PRs. IMHO, it's a required skill if you want to work more on GitHub and other platforms.

@Akshay2131
Copy link
Contributor Author

ok, i got it..
i will try it with my own repos to get good command on it..
Thanks..

Copy link
Member

@utzcoz utzcoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@utzcoz utzcoz requested a review from hoisie April 17, 2022 14:56
@hoisie hoisie merged commit af83216 into robolectric:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate compileSdkVersion to compileSdk for Robolectric's tests
3 participants