Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make deep copy of mPointerProperties for NativeInput#copyFrom #7251

Merged
merged 1 commit into from Apr 17, 2022
Merged

Make deep copy of mPointerProperties for NativeInput#copyFrom #7251

merged 1 commit into from Apr 17, 2022

Conversation

utzcoz
Copy link
Member

@utzcoz utzcoz commented Apr 16, 2022

Close #7242

@utzcoz
Make deep copy of mPointerProperties for NativeInput#copyFrom
99d8376 
Signed-off-by: utzcoz <utzcoz@outlook.com>
@utzcoz utzcoz mentioned this pull request Apr 16, 2022
Closed
@utzcoz utzcoz requested a review from hoisie April 16, 2022 09:18
@hoisie
Copy link
Contributor

hoisie commented Apr 17, 2022

Thanks for this PR, I am running some extra validation internally at Google to catch any potential issues.

hoisie
hoisie approved these changes Apr 17, 2022
View reviewed changes
Copy link
Contributor

@hoisie hoisie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@utzcoz utzcoz merged commit 5f36029 into robolectric:master Apr 17, 2022
@utzcoz utzcoz deleted the deep-copy-for-mPointerProperties branch April 17, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoisie hoisie hoisie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NativeInput.MotionEvent.copyFrom does not make a deep copy of PointerProperties[]
2 participants
@utzcoz @hoisie