Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed targetSdk from AndroidManifest.xml #7232

Merged
merged 1 commit into from Apr 16, 2022
Merged

Removed targetSdk from AndroidManifest.xml #7232

merged 1 commit into from Apr 16, 2022

Conversation

Umesh-01
Copy link
Contributor

@Umesh-01 Umesh-01 commented Apr 9, 2022

Overview

#6966

Proposed Changes

Removed targetSdk from AndroidManifest.xml and moved the version from the manifest to the defaultConfig in the build.gradle file.

Affected Modules: parent.integration_tests.androidx, parent.integration_tests.androidx_test, parent.integration_tests.ctesque, parent.integration_tests.memoryleaks, parent.testapp

@Umesh-01
Copy link
Contributor Author

Umesh-01 commented Apr 9, 2022

@utzcoz please review this one.

@utzcoz
Copy link
Member

utzcoz commented Apr 10, 2022

@Umesh-01 could you remove link information to your fork repo from your commit message? Thanks.

@Umesh-01
removed targetSdk from Android manifest files
6688f5e 
* removed targetSdk from androidx

* removed targetSdk from androidx_test

* removed targetSdk from ctesque

* removed targetSdk from memoryleaks

* removed targetSdk from testapp
@Umesh-01
Copy link
Contributor Author

@Umesh-01 could you remove link information to your fork repo from your commit message? Thanks.

Is it fine now??

@utzcoz utzcoz requested a review from hoisie April 10, 2022 07:25
@utzcoz
Copy link
Member

utzcoz commented Apr 10, 2022

Hi @hoisie , does internal code base use targetSdk in AndroidManifest.xml?

utzcoz
utzcoz approved these changes Apr 16, 2022
View reviewed changes
Copy link
Member

@utzcoz utzcoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@utzcoz
Copy link
Member

utzcoz commented Apr 16, 2022

Hi @hoisie , does internal code base use targetSdk in AndroidManifest.xml?

Hi @hoisie , could you help to review this PR? Thanks.

hoisie
hoisie approved these changes Apr 16, 2022
View reviewed changes
Copy link
Contributor

@hoisie hoisie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@utzcoz utzcoz merged commit cf28b2b into robolectric:master Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoisie hoisie hoisie approved these changes

@utzcoz utzcoz utzcoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Umesh-01 @utzcoz @hoisie