Add getCurrentSyncs() in ShadowContentResolver #7225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utzcoz
requested changes
Apr 8, 2022
shadows/framework/src/main/java/org/robolectric/shadows/ShadowContentResolver.java
Show resolved
Hide resolved
utzcoz
reviewed
Apr 8, 2022
shadows/framework/src/main/java/org/robolectric/shadows/ShadowContentResolver.java
Show resolved
Hide resolved
|
Please read https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue to learn how to link your PR with issue. |
utzcoz
reviewed
Apr 8, 2022
robolectric/src/test/java/org/robolectric/shadows/ShadowContentResolverTest.java
Show resolved
Hide resolved
utzcoz
reviewed
Apr 8, 2022
shadows/framework/src/main/java/org/robolectric/shadows/ShadowContentResolver.java
Outdated
Show resolved
Hide resolved
utzcoz
reviewed
Apr 8, 2022
shadows/framework/src/main/java/org/robolectric/shadows/ShadowContentResolver.java
Outdated
Show resolved
Hide resolved
shadows/framework/src/main/java/org/robolectric/shadows/ShadowContentResolver.java
Outdated
Show resolved
Hide resolved
utzcoz
reviewed
Apr 8, 2022
shadows/framework/src/main/java/org/robolectric/shadows/ShadowContentResolver.java
Outdated
Show resolved
Hide resolved
utzcoz
approved these changes
Apr 9, 2022
|
Hi @hoisie , could you help to review this PR? Thanks. |
hoisie
approved these changes
Apr 16, 2022
|
Not a big deal, but in general I like to see formatting changes in separate commits, as it keeps git commit history cleaner. |
I prefer to combine formatting with related changed, because code change maybe bring new formatting problem. If separate commits for formatting are acceptable, I will not request contributors to do it at later review progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added getCurrentSyncs() in ShadowContentResolver.
Close #7191
Proposed Changes
Added getCurrentSyncs() method will return a list of currently active syncs,