Support Canvas#drawRect with RectF #7210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Akshay2131 Please follow https://github.com/robolectric/robolectric/wiki/Robolectric's-code-style to format your commits locally before pushing. |
|
@Akshay2131 could you squash two commits to one? And you don't need to add formatted to your commit message. Thanks. |
|
@utzcoz Could you please review new commit? |
|
Thanks @akshay213! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related to PR : drawRect_toCanvas() added #7197
Fixed the issue "Bitmap-backed canvas.drawRect fails with paint" #7188
Proposed Changes
New methods and test cases added to support Rectangle drawing using paint in canvas.