Fixed PFD testGetFd_canRead test failed on macOS. #7202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utzcoz
reviewed
Apr 3, 2022
robolectric/src/test/java/org/robolectric/shadows/ShadowParcelFileDescriptorTest.java
Outdated
Show resolved
Hide resolved
ZSmallX
force-pushed
the
pfd_tests_on_multiple_platforms
branch
from
86f74e5
to
54564d5
Compare
utzcoz
reviewed
Apr 3, 2022
robolectric/src/test/java/org/robolectric/shadows/ShadowParcelFileDescriptorTest.java
Outdated
Show resolved
Hide resolved
|
I have tested it on my macOS with M1, and the test passed. |
Used `new FileInputStream(FileDescriptor)` instead of `new FileInputStream(String)`. Avoid depending on Linux file system details, and make full use of Java cross platform feature. Notes: it can still run failed on Windows. Signed-off-by: ZSmallX <diosmallx@gmail.com>
ZSmallX
force-pushed
the
pfd_tests_on_multiple_platforms
branch
from
54564d5
to
cd6430f
Compare
|
Thanks @ZSmallX ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixed PFD testGetFd_canRead test failed on macOS.
Avoid depending on Linux file system details, and make full use of Java cross platform feature.
Proposed Changes
Used
new FileInputStream(FileDescriptor)instead ofnew FileInputStream(String).Note that it can still run failed on Windows.
Closes #7130