New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI job to build nativeruntime for Windows #6923
Add CI job to build nativeruntime for Windows #6923
Conversation
e6797a0
to
00b6b84
Compare
5010da4
to
031071b
Compare
I found a very strange problem: the cache restored, but restored icu-bin doesn't have generated .a files. |
Looks like I should find a method to pass value to |
e7488e3
to
fd72b1a
Compare
I decided to use hard-coded file name to replace |
ea99fdb
to
0cf016d
Compare
I updated cache key with adding |
There is another weird problem: Windows generated dll file is small, about 5~6MB, less than other platforms' file size: about 30MB. |
@hoisie I think this PR is ready for initial review to looking forward your suggestion. |
This is very likely a libICU data issue. The libICU data file alone is like 25 MB, which could explain the difference. I don't think it's urgent to fix this right away. The libICU sqlite integration is only used for Anyway, I am ok with getting the build working first, and then we can figure out the runtime issues. |
Thanks. I will give more tries for CI's cache for msys2 to reduce CI times, and omit this dll size problem now. |
9f204a3
to
5a531b2
Compare
Looks like we can set |
5ccd3b1
to
6a78a4c
Compare
Oh, it works, and Windows building time reduced to 3min from 20min. There are some clean-up needs to be done. I will clean up those scripts this weekend for final reviewing. :) |
6ac1248
to
4cf42ad
Compare
@hoisie I think it can be reviewed again. I have tested it with cache, and Windows cache works fine. The things to clean up cmake and CI jobs will be left for later PRs, if possible. |
Hi @hoisie , could you help to review this PR again? I plan to merge it if there is no any important problem should be resolved. Thanks. |
Signed-off-by: utzcoz <utzcoz@outlook.com>
4cf42ad
to
b6f1fc3
Compare
@hoisie Looks like self-runner encounters problem again. |
https://github.com/robolectric/robolectric/runs/4704128816?check_suite_focus=true instrumentation-tests failed because of network problem to downloading gradle. |
For #6791.