Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SDK version check for onPageFinished() call. It should be available for all SDK versions instead. See https://developer.android.com/reference/android/webkit/WebViewClient#onPageFinished(android.webkit.WebView,%20java.lang.String) #6865

Merged
merged 1 commit into from Nov 17, 2021
Merged

Fix SDK version check for onPageFinished() call. It should be available for all SDK versions instead. See https://developer.android.com/reference/android/webkit/WebViewClient#onPageFinished(android.webkit.WebView,%20java.lang.String) #6865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion shadows/framework/src/main/java/org/robolectric/shadows/ShadowWebView.java
View file
Open in desktop
Expand Up @@ -277,7 +277,7 @@ private void performSuccessfulPageLoad(String url) {
webChromeClient.onReceivedTitle(realWebView, url);
webChromeClient.onProgressChanged(realWebView, 100);
}
if (webViewClient != null && VERSION.SDK_INT >= 23) {
if (webViewClient != null) {
webViewClient.onPageFinished(realWebView, url);
}
});
Expand Down