Shadow Build.VERSION#MEDIA_PERFORMANCE_CLASS #6836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_408717180
branch
from
b9fe0a5
to
c5072a1
Compare
|
Hi @hoisie, looks like this PR has changes that removing support v4 shadows. Is it better to remove it at 4.8 release? |
copybara-service
bot
force-pushed
the
piper_408717180
branch
2 times, most recently
from
947d123
to
990d274
Compare
Performance class was added in Android S. See https://developer.android.com/topic/performance/performance-class PiperOrigin-RevId: 408717180
hoisie
force-pushed
the
piper_408717180
branch
from
990d274
to
f279da2
Compare
|
@utzcoz that was unintentional, sorry for the confusion. We were doing some work at Google to prepare for removing the support library shadows in Robolectric, and for some reason that confused Copybara. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shadow Build.VERSION#MEDIA_PERFORMANCE_CLASS
Performance class was added in Android S.
See https://developer.android.com/topic/performance/performance-class