Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add ActivityController.close that transitions Activity to destroyed s…
…tate Update ActivityController to implement AutoCloseable, and add a 'close' method that is lifecycle-aware and transitions the underlying Activity to the destroyed state, freeing all resources and making the Activity eligible for gc. This is a convenient way to ensure that ActivityControllers can be freed without having to manage the underlying Activity lifecycles. It also enables ActivityController to be managed using try-with-resources. PiperOrigin-RevId: 410291892
- Loading branch information
Showing
2 changed files
with
104 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feaded1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does close need to be called to prevent
Activity
objects being leaked during tests?feaded1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @seadowg , could you file a new issue to discuss it? The discussion under commit can't be tracked and indexed well.
feaded1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! #7041